On Sat, 1 Jun 2013 14:21:52 +0200 Stefan Tauner <[email protected]> wrote:
> On Wed, 21 Nov 2012 00:07:40 +0100 > Carl-Daniel Hailfinger <[email protected]> wrote: > > > +# This parameter picks the default setting for CONFIG_ variables of > > programmers not specified explicitly > > +# on the command line. > > +CONFIG_DEFAULT ?= yes > > i dont like "picks" in there. whats wrong with configures, selects, > sets? :) > > also, i would rename CONFIG_DEFAULT because it is not specific enough. > e.g. there is also CONFIG_PRINT_WIKI which is not (and should not be) > affected by this setting. i propose CONFIG_PROGRAMMER_DEFAULT_STATE. > yes, that is awfully long, but much clearer. a part of the problem is > that we already have a CONFIG_DEFAULT_PROGRAMMER that we need to keep > recognizably different. > > > # Disable Dediprog SF100 until support is complete and tested. > > CONFIG_DEDIPROG ?= no > > [etc] > > whats the rationale to exclude those? IMHO it makes sense to enable them > too with CONFIG_DEFAULT. ping, I want this in. Even with the controversial points above. If I dont hear back from you, Ill rebase, change according to my comments above and commit. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
