On Tue, 18 Feb 2014 11:00:52 +0100 Marcin Kościelnicki <[email protected]> wrote:
> Signed-Off-By: Marcin Kościelnicki <[email protected]> > > Index: chipset_enable.c > =================================================================== > --- chipset_enable.c (revision 1764) > +++ chipset_enable.c (working copy) > @@ -1075,6 +1075,15 @@ > return 0; > } > > +static int enable_flash_nvidia_nforce(struct pci_dev *dev, const char > *name) > +{ > + rpci_write_byte(dev, 0x7a, 0); > + if (enable_flash_nvidia_common(dev, name)) > + return ERROR_NONFATAL; > + else > + return 0; > +} > + > static int enable_flash_nvidia_nforce2(struct pci_dev *dev, const char > *name) > { > rpci_write_byte(dev, 0x92, 0); > @@ -1417,6 +1426,7 @@ > {0x10de, 0x00e0, OK, "NVIDIA", "NForce3", > enable_flash_nvidia_nforce2}, > /* Slave, should not be here, to fix known bug for A01. */ > {0x10de, 0x00d3, OK, "NVIDIA", "CK804", > enable_flash_ck804}, > + {0x10de, 0x01b2, OK, "NVIDIA", "NForce", > enable_flash_nvidia_nforce}, > {0x10de, 0x0260, OK, "NVIDIA", "MCP51", > enable_flash_ck804}, > {0x10de, 0x0261, NT, "NVIDIA", "MCP51", > enable_flash_ck804}, > {0x10de, 0x0262, NT, "NVIDIA", "MCP51", > enable_flash_ck804}, > Hello Marcin, thanks for your patch! Can you please give us a bit of background information? AFAIK the datasheets of this chipset were never public. Did you RE it for a specific board? (then why is there no report on that? :) I also wonder if we should check that the write in enable_flash_nvidia_nforce sticks and return with an error otherwise? -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
