On Thu, 27 Feb 2014 14:33:31 +0000 [email protected] wrote: > Quoting Stefan Tauner <[email protected]>: > > Hello Jason, > > > > thanks for the patch. It looks good apart from the .tested field which > > should be set to TEST_OK_PREW and I'd like to commit it. For that we > > need a proper declaration of authorship though. Please see > > http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure > > Ok, my previous patch is hereby... > Signed-off-by: Jason Harper <[email protected]>
Acked-by: Stefan Tauner <[email protected]> and committed in r1785. Additionally, I have refined status register prettyprinting and unlocking of the whole family. > I didn't feel comfortable setting the .tested field, given the > extremely brief nature of my testing, and the fact that I just copied > an existing SST device that was itself untested. Nothing I did would > have verified that the smaller erase block sizes were correct, for > example. Good enough, or at least equivalent to the flag's semantics ;) BTW flashrom uses the smallest (first) erase block size... so you have just tested the 4k eraser and not the *bigger* ones. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
