On Fri, 16 May 2014 18:11:50 +0200 The Raven <[email protected]> wrote:
> > You will have to sign off the patch with your real name too. > > http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure > > Since I doubt that this patch reaches the threshold of originality > > needed to become "your" work (at least in somewhat sane jurisdictions), > > I can also sign it off myself if you prefer that, but IMHO you should > > stand by your work. :) > Please add the patch. It's tested and seems to work with > the "LE25FW406A". I can do more testing and logs if you like. > > Since we do not have a datasheet for this chip, it would be good if you > > could test all erase functions dedicatedly by commenting out all but > > one eraser block in flashchips.c (Since flashrom tries the top most > > first, you can leave out testing it), e.g.: > > // .eraseblocks = { {4 * 1024, 128} }, > > // .block_erase = spi_block_erase_d7, > > // }, { > Agree with you, unfortunately we have no Datasheet. > I have tested all erase functions. Before erasing i have filled the chip > always with random data from "dd". > It seems that all erase functions work as they should. :-) > And writing and reading too. Thank you. After private discussion (with the author) I have decided to sign off the patch myself. I have committed it in r1796 after minor refinements. -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
