On Mon, 16 Jun 2014 02:10:46 +0200 Carl-Daniel Hailfinger <[email protected]> wrote:
> Am 29.08.2012 06:32 schrieb Stefan Tauner: > > On Wed, 29 Aug 2012 02:06:11 +0200 > > Carl-Daniel Hailfinger <[email protected]> wrote: > > > > you have renamed the types, but not the variables. > > should i fix that or do you want to do that yourself? This could have been in for about 2 years if there would have been an email with a single word in it. > Updated patch. This should compile and work, and fix the stuff which > came up in the review. > > TODO for a followup patch (or possibly this one): Let's get this in first please. It is self-contained and makes sense on its own. > - should we create a new struct programmer pgm, and should it contain > one/all master(s)? > -- contains common stuff like flashbase > -- contains specific stuff like ipport addresses > -- union for some stuff? > -- names for individual masters (useful if multiple masters are present) > > Signed-off-by: Carl-Daniel Hailfinger <[email protected]> I think it does not even need a rebase? So this looks good to get in now, thank you! Acked-by: Stefan Tauner <[email protected]> -- Kind regards/Mit freundlichen Grüßen, Stefan Tauner _______________________________________________ flashrom mailing list [email protected] http://www.flashrom.org/mailman/listinfo/flashrom
