On Wed, 10 Dec 2014 21:24:27 +0400
Roman Lebedev <[email protected]> wrote:

> Invalid locking change 0xf8 requested at 0xb7323002! Please report a bug at
> [email protected]

Thanks for testing Roman!

Carl-Daniel, do you have any idea why we do the "new_bits & ~REG2_MASK"
in changelock_regspace2_block() in jedec.c at all?
It is essentially your code, c.f.
http://patchwork.coreboot.org/patch/3412/

I propose to use "(old ^ new) & ~REG2_MASK" instead, i.e. check if the
caller requests a change of bits not related to the write protection. I
guess that was your original intention anyway, is that correct?
-- 
Kind regards/Mit freundlichen Grüßen, Stefan Tauner

_______________________________________________
flashrom mailing list
[email protected]
http://www.flashrom.org/mailman/listinfo/flashrom

Reply via email to