Hey Carl-Daniel, I think it would be great if we could think up more areas of the code base to write some additional unit-tests for? Those tests now run as part of gerrit review however our coverage at the moment is not significant enough to be useful in a reasonable sense. We should set about improving that and get rid of some more global variables out the codebase by finishing off the migration to the rentrent design of register_mst, i.e., use the void *data member more. On the subject of runtime testing, I am not sure it is a good place for it as it is analogous to a complex take of a runtime asserts, the tests should run as part of the development process and not each time part of the users invocation process.
Food for thought. Kind regards, Edward. On Wed, 10 Feb 2021 at 04:36, Carl-Daniel Hailfinger <c-d.hailfinger.devel.2...@gmx.net> wrote: > > [Adding flashrom mailing list to CC. Context: The Ubuntu bug is about > moving flashrom from universe to main. > See https://bugs.launchpad.net/ubuntu/+source/flashrom/+bug/1912371/ for > details.] > > If anyone is interested, I can dig up my test scripts which I used to > test flashrom, but I do not have any autopkgtest experience. Someone(TM) > would have to convert that to autopkgtest format, or we can simply ship > selftest scripts to be called from autopkgtest. > The amount of testing depends on how much test coverage you want. We can > do self-tests with internally emulated hardware or externally emulated > hardware or real hardware (the last variant is probably not desirable in > a build system). > Besides that, flashrom always performs a few self-tests (mostly internal > data structure consistency) during startup. The tests have repeatedly > caught bugs before a merge when people added new features, but forgot to > update all relevant data structures. > _______________________________________________ > flashrom mailing list -- flashrom@flashrom.org > To unsubscribe send an email to flashrom-le...@flashrom.org _______________________________________________ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
