Hi Thomas,

I have submitted the patch on Gerrit, kindly review.

Regards,
Chinmay Lonkar

On Wed, May 11, 2022 at 11:28 PM Thomas Heijligen <s...@posteo.de> wrote:
>
> Hi Chinmay,
>
> Thanks for adding voltage informations to those chips.
> Can you plese upload the patch to Gerrit. https://review.coreboot.org
>
> There are usefull HOWTOs in the flashrom wiki and coreboot doc.
> https://www.flashrom.org/Development_Guidelines#Sending_a_patch
> https://doc.coreboot.org/tutorial/part2.html
>
> Thanks
> -- Thomas
>
> On Wed, 2022-05-11 at 23:17 +0530, Chinmay Lonkar wrote:
> > From: ChinmayLonkar <chinmay20...@gmail.com>
> >
> > This patch adds voltage data for following chips:
> > * Intel 28F002BC/BL/BV/BX-T
> > * Intel 28F004B5/BE/BV/BX-B
> > * Intel 28F004B5/BE/BV/BX-T
> > * Intel 28F008S3/S5/SC
> > * Intel 28F400BV/BX/CE/CV-B
> > * Intel 28F400BV/BX/CE/CV-T
> > * Micron/Numonyx/ST M25P40-old
> > * SyncMOS/MoselVitelic {F,S,V}29C51002T
> > * Winbond W29C010(M)/W29C011A/W29EE011/W29EE012
> > * Winbond W29C010(M)/W29C011A/W29EE011/W29EE012-old
> >
> > Change-Id: I42bc546e03a899086c034c026231955088a7d400
> > Signed-off-by: Chinmay Lonkar <chinmay20...@gmail.com>
> > ---
> >  flashchips.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/flashchips.c b/flashchips.c
> > index d155b24..f9cb0cd 100644
> > --- a/flashchips.c
> > +++ b/flashchips.c
> > @@ -8112,6 +8112,7 @@ const struct flashchip flashchips[] = {
> >                 },
> >                 .write          = write_82802ab,
> >                 .read           = read_memmapped,
> > +               .voltage        = {4500, 5500},
> >         },
> >
> >         {
> > @@ -8139,6 +8140,7 @@ const struct flashchip flashchips[] = {
> >                 },
> >                 .write          = write_82802ab,
> >                 .read           = read_memmapped,
> > +               .voltage        = {4500, 5500},
> >         },
> >
> >         {
> > @@ -8166,6 +8168,7 @@ const struct flashchip flashchips[] = {
> >                 },
> >                 .write          = write_82802ab,
> >                 .read           = read_memmapped,
> > +               .voltage        = {4500, 5500},
> >         },
> >
> >         {
> > @@ -8189,6 +8192,7 @@ const struct flashchip flashchips[] = {
> >                 .unlock         = unlock_28f004s5,
> >                 .write          = write_82802ab,
> >                 .read           = read_memmapped,
> > +               .voltage        = {2700, 3300},
> >         },
> >
> >         {
> > @@ -8217,6 +8221,7 @@ const struct flashchip flashchips[] = {
> >                 },
> >                 .write          = write_82802ab,
> >                 .read           = read_memmapped,
> > +               .voltage        = {2700, 3600},
> >         },
> >
> >         {
> > @@ -8245,6 +8250,7 @@ const struct flashchip flashchips[] = {
> >                 },
> >                 .write          = write_82802ab,
> >                 .read           = read_memmapped,
> > +               .voltage        = {2700, 3600},
> >         },
> >
> >         {
> > @@ -10521,6 +10527,7 @@ const struct flashchip flashchips[] = {
> >                 .unlock         = spi_disable_blockprotect_bp3_srwd,
> >                 .write          = spi_chip_write_256,
> >                 .read           = spi_chip_read,
> > +               .voltage        = {2300, 3600},
> >         },
> >
> >         {
> > @@ -16884,6 +16891,7 @@ const struct flashchip flashchips[] = {
> >                 },
> >                 .write          = write_jedec_1,
> >                 .read           = read_memmapped,
> > +               .voltage        = {4500, 5500}
> >         },
> >
> >         {
> > @@ -16910,6 +16918,7 @@ const struct flashchip flashchips[] = {
> >                 },
> >                 .write          = write_jedec_1,
> >                 .read           = read_memmapped,
> > +               .voltage        = {4500, 5500}
> >         },
> >
> >         {
> > @@ -18607,6 +18616,7 @@ const struct flashchip flashchips[] = {
> >                 },
> >                 .write          = write_jedec,
> >                 .read           = read_memmapped,
> > +               .voltage        = {4500, 5500},
> >         },
> >
> >         {
> > @@ -18630,6 +18640,7 @@ const struct flashchip flashchips[] = {
> >                 },
> >                 .write          = write_jedec,
> >                 .read           = read_memmapped,
> > +               .voltage        = {4500, 5500},
> >         },
> >
> >         {
>
_______________________________________________
flashrom mailing list -- flashrom@flashrom.org
To unsubscribe send an email to flashrom-le...@flashrom.org

Reply via email to