Hi Stefan, On 26.06.22 19:30, Stefan Reinauer wrote: > On Sun, Jun 26, 2022 at 7:14 AM Nico Huber <nic...@gmx.de> wrote: > >> Hi Martin, >> >> For half >> of the programmers Google adds, it turns out soon after that they are >> unused and nobody can test them, not even at Google. > > > Which ones in particular did you have in mind here?
hmmm, from the top of my head, I read this about the realtek_mst_i2c_spi programmer recently [1]: >> Fixups suggest that the original code wasn't properly tested, >> was it by now? > > It worked the last time I wanted to use it, but nothing uses this > in production so it's not actively tested. I guess that's still testable. But would it be worth the effort if we decided to keep only tested hw support? The two extreme cases I remember were EC interfaces, ene* something and mec* something. We removed them again already. They were merged about last year, but turned out to be for some of the first chromebooks. After some fixups to the integration, people wanted to write unit tests for them, and then we realized that the code couldn't work. Nico [1] https://ticket.coreboot.org/issues/361 _______________________________________________ flashrom mailing list -- flashrom@flashrom.org To unsubscribe send an email to flashrom-le...@flashrom.org
