Hello Vincent, > were hesitant to submit a patch since the sample size was so low.
I think it would be good to push a patch in Gerrit anyway. Given that there is a FIXME in the code, there would be some patch one way or the other. Thank you so much for fixing the old FIXME The patch can be downloaded in case someone wants to help testing, we have instructions https://flashrom.org/dev_guide/development_guide.html#downloading-patch-from-gerrit People can add Tested-by in the commit message, or add comments. You can warn in commit message that it needs more testing and link the ticket. Thank you! On Tue, Sep 23, 2025 at 8:17 AM Vincent Fazio <[email protected]> wrote: > > We recently ran into an issue reading data from some chips via Dediprog > (https://ticket.coreboot.org/issues/609). > > It appears to be related to maybe not taking some I/O pins into account: > https://github.com/flashrom/flashrom/blob/05976c7e93ea64031f6bb3b1eee8120234d7202e/dediprog.c#L267 > > We have a diff in the ticket that worked for us on our specific combination > of dediprog + firmware + flashchips but were hesitant to submit a patch since > the sample size was so low. > > Does anyone else use a Dediprog to program flash and has capacity to try the > changes and see if things break or if their use cases start working where > they failed before? > > Vincent Fazio > Automated Test Software, Technical Lead > Extreme Engineering Solutions, Inc. > https://www.xes-inc.com > > _______________________________________________ > flashrom mailing list -- [email protected] > To unsubscribe send an email to [email protected] -- Anastasia. _______________________________________________ flashrom mailing list -- [email protected] To unsubscribe send an email to [email protected]
