@tohojo requested changes on this pull request.
That's better! One more small nit below. Also, the commit message you added is
great, but please squash the two commits together so that it becomes one commit
that keeps the heading of the first one, and has the text of the second commit
as its body.
Also, this sentence:
> Using the option will cause netperf to fail noisily, in case the specified
> file is not readable or does not exist.
is slightly misleading. It's not netperf that fails noisily, it's the check in
flent. So maybe "Flent will check if the file is readable before passing it to
netperf, and fail the test run if it isn't" ?
> except RunnerCheckError:
- netperf['buffer'] = ''
+ if(fill_file == '/dev/urandom'):
+ netperf['buffer'] = ''
+ else:
+ # If the custom file is not readable, fail noisily
+ raise RunnerCheckError("The specified fill file does not
exist or is not readable.")
The option is --test-payload, so referring to "fill file" in the error message
is going to confuse people. Better stick to "test payload" here as well :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tohojo/flent/pull/243#pullrequestreview-785005703_______________________________________________
Flent-users mailing list -- flent-users@flent.org
To unsubscribe send an email to flent-users-le...@flent.org
