[
https://issues.apache.org/jira/browse/FLEX-33132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404146#comment-13404146
]
David Fisher commented on FLEX-33132:
-------------------------------------
I've reviewed the report. Only a few files to comment on:
(1) Should a "fork" carry another project's KEYS? I think not.
modules/thirdparty/batik/KEYS
(2) The following readme is no longer needed, the contents of the directory are
all AL2.
frameworks/projects/framework/src/mx/readme.txt
(3) Why does RAT miss the AL Headers in these files?
modules/antTasks/README.txt
modules/asc/build/util/README.txt
(4) Does this file need a header? Opinions might differ.
modules/thirdparty/velocity/src/java/org/apache/flex/forks/velocity/runtime/parser/build
Nothing here is a blocker. I would fix (1) and (2)
Regards,
Dave
> Apache Flex 4.8.0 (parity release) Release Candidate
> ----------------------------------------------------
>
> Key: FLEX-33132
> URL: https://issues.apache.org/jira/browse/FLEX-33132
> Project: Apache Flex
> Issue Type: Task
> Components: Installation & Packaging
> Affects Versions: Apache Flex 4.8 (parity release)
> Reporter: Carol Frampton
> Assignee: Bertrand Delacretaz
> Attachments: rat.log
>
>
> Attached is the RAT report (rat.log) for the files in the source kit. The
> current kits are available from
> http://people.apache.org/~cframpton/ApacheFlexRC/current/
> The exclusions from the report are:
> <fileset dir="${rat.dir}">
> <!-- Start of binary files -->
> <!-- exclude Flash Professional file used for integration
> with Flash Professional -->
> <exclude
> name="frameworks/projects/flash-integration/FLA/ContentHolder.fla"/>
> <!-- exclude font embedded in asdoc example -->
> <exclude
> name="frameworks/projects/framework/asdoc/en_US/mx/effects/examples/assets/OpenSans-Regular.ttf"/>
> <!-- exclude media (png, gif, jpg, mp3, flv) -->
> <exclude name="**/*.png"/>
> <exclude name="**/*.gif"/>
> <exclude name="**/*.jpg"/>
> <exclude name="**/*.mp3"/>
> <exclude name="**/*.flv"/>
> <!-- End of binary files -->
> <!-- exclude batik manifests -->
> <exclude name="modules/thirdparty/batik/sources/*.mf"/>
> <!-- exclude w3c sources -->
> <exclude
> name="modules/thirdparty/batik/resources/org/apache/flex/forks/batik/dom/svg/resources/*.mod"/>
> <exclude
> name="modules/thirdparty/batik/resources/org/apache/flex/forks/batik/dom/svg/resources/*.dtd"/>
> <exclude
> name="modules/thirdparty/batik/sources/org/w3c/flex/forks/css/sac/*.java"/>
> <exclude
> name="modules/thirdparty/batik/sources/org/w3c/flex/forks/css/sac/helpers/ParserFactory.java"/>
> <!-- exclude config files -->
> <exclude
> name="modules/thirdparty/xerces-patch/src/java/META-INF/services/javax.xml.parsers.SAXParserFactory"/>
> <exclude
> name="modules/thirdparty/xerces-patch/src/java/META-INF/services/org.apache.xerces.xni.parser.XMLParserConfiguration"/>
> <exclude
> name="modules/thirdparty/xerces-patch/src/java/org/apache/xerces/jaxp/javax.xml.parsers.SAXParserFactory"/>
> </fileset>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
