Hi, On Fri, Aug 31, 2012 at 9:44 AM, Om <bigosma...@gmail.com> wrote: > ...The source distributions for Windows and Mac are available here: > http://people.apache.org/~bigosmallm/installapacheflex_RC1/
Thanks - I'm currently -1 on releasing that, nothing major but a number of questions: 1) IMO the mention of the as3corelib stuff in NOTICE is not required - it's license is in LICENCE, that's fine. 2) The LICENCE file contains extra stuff (like frameworks/src/mx/effect/easing for example) that should be removed. 3) What's ./src/assets/fonts/open-sans/Apache License Version 2.txt ? If the font files in there are Apache licensed that should be mentioned in LICENCE. 4) apache-flex-sdk-installer-1.0.0-incubating-src.tar.gz contains (Eclipse I assume) .project and other similar files, do they really belong in there? We don't usually release such files. 5) build.properties contains things like installer.url.win=http://people.apache.org/~bigosmallm/installapacheflex/InstallApacheFlex.exe is that what you want? If people are meant to put their own settings in that build.properties file I'd recommend using example.com or other URLs that don't point to apache.org. 6) in build.properties, KEYSTORE=installapacheflex_self.p12 - has the signing process for that file been solved? Do we have a jira issue that explains how that's handled? 7) IIUC the README is meant for Flex committers to release that package? It mentions gpg signing the output etc. - shouldn't that be made clear in that file? 8) It looks like building this requires Flash Builder - should be mentioned upfront in the README. 9) IIUC the goal of the installer is for Flex users to download the Apache Flex SDK - if yes that needs to happen via mirrors to avoid hitting apache.org directly. I haven't followed the details but it seems like the installer is indeed using mirrors - do we have docs or a jira issue that explains how that works? I'd like to review that before the installer is out in the wild. Lots of points but as I said nothing major, 6) and 9) are my main concerns. -Bertrand
