Hello Alex, I've just checked out the source for the installer. I'll spend some time trying to build and check if all is right. After a quick look in the class responsible for the locale settings, I see some more changes that can happen so as soon as I figure out how the process works I'll submit a patch with the new changes.
Regarding the JIRA issue, what do you want me to include in there? On Thu, Jan 3, 2013 at 7:02 PM, Alex Harui <aha...@adobe.com> wrote: > Hi Nick, I checked in your suggested changes. If you have time, please > build it and test it yourself. At minimum, check it when you see RC2 > announced. > > Also, please open a JIRA issue and copy your email into it. I tend to use > JIRA to track who we've accepted contributions from. > > Om, I've checked the rat report and ran the installer in english last > night. > Everything seems to be ok, so I'm ready for RC2. > > Thanks, > -Alex > > On 1/3/13 8:19 AM, "Alex Harui" <aha...@adobe.com> wrote: > > > > > > > > > On 1/3/13 5:57 AM, "Nick Tsitlakidis" <ni...@perfectedz.com> wrote: > > > >> More than happy to do it but I would like to have some guidance for > this. > >> I'm a total noob with patches since it's the first time I'm actively > >> contributing something. I'm a member of the list since last year but > never > >> had the time to work on something until now. > >> > >> Are there any guidelines or a page I can check to learn how to do this? > > There is some information on the Apache Flex web site. You have to check > out > > the source, figure out how to build the installer, modify the files and > > generate the patch from the modified files. The way you generate the > patch > > depends on what kind of SVN client you are using. > > > > But for now, I will try to see if I can just copy/paste your changes. > > -- > Alex Harui > Flex SDK Team > Adobe Systems, Inc. > http://blogs.adobe.com/aharui > > -- Nick Tsitlakidis, CEO and Software Architect at Perfect Edge LTD. www.perfectedz.com
