Sure, I will apply it right away.... I may got to the file thing in the future, but for sure not gonna happen anytime soon, so it is likely your change will be there for ever =D
On Tue, Jul 27, 2010 at 5:06 PM, Jesse Sightler <[email protected]>wrote: > I don't really see how it would be slower than reading and parsing hundreds > (if not thousands) of separate files. It also brings in the issue of > parsing as code to accurately determine if it includes classes. > > Honestly, I'd greatly prefer a link-report based solution to something > based on guessing the files used. I don't really care about coverage for > files that aren't in the SWF anyway. :) Really, I could see where some > people would prefer to have both options available to them. > > If I send a prototype of this approach (link-report parsing), would it be > likely to get considered for inclusion? > > Thanks, > Jess > > > On Tue, Jul 27, 2010 at 12:13 PM, Marvin Froeder <[email protected]>wrote: > >> link-report would be more accurate (I guess), but it would be slower >> (parsing xml) and still my left classes behind..... test code coverage >> should check coverage of all classes, not only the used by the APP..... >> >> This advanced scanner (as a configurable thing) I'm more willing to >> include on flexmojos. >> >> VELO >> >> >> On Tue, Jul 27, 2010 at 1:00 PM, Jesse Sightler <[email protected] >> > wrote: >> >>> I think that could work for most cases. I'm wondering, though... would >>> that actually be easier than a link-report scanner? It seems like that >>> would be the most accurate way to do it. >>> >>> In any case, I do think that it would work for us. It would force us to >>> remove some non-compilable class files, but I don't really see that as a bad >>> thing. :) >>> >>> Thanks, >>> Jess >>> >>> >>> On Tue, Jul 27, 2010 at 10:45 AM, Marvin Froeder <[email protected]>wrote: >>> >>>> Ithink a better approach would be an advanced class scanner... that >>>> checks if the .as file is a class, probably just check for class keyword >>>> presence.... >>>> >>>> What do you think? >>>> >>>> Sent from DROID >>>> >>>> Em 26/07/2010 23:09, "Jesse Sightler" <[email protected] >>>> >escreveu: >>>> >>>> >>>> LOL, that is fine. At least the attached patch there gets us past our >>>> problem for now. >>>> >>>> We look forward to seeing a more official solution as well. :) >>>> >>>> Thanks, >>>> Jess >>>> >>>> >>>> On Mon, Jul 26, 2010 at 9:44 PM, Marvin Froeder <[email protected]> >>>> wrote: >>>> >>>>> > >>>>> > You did convinced me this need an different approach, you just didn't >>>>> convinced me that the sugg... >>>>> >>>>> -- >>>>> >>>>> > You received this message because you are subscribed to the Google >>>>> > Groups "Flex Mojos" group. >>>>> > ... >>>>> >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Flex Mojos" group. >>>> To... >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Flex Mojos" group. >>>> To post to this group, send email to [email protected] >>>> To unsubscribe from this group, send email to >>>> [email protected]<flex-mojos%[email protected]> >>>> For more options, visit this group at >>>> http://groups.google.com/group/flex-mojos >>>> >>>> http://flexmojos.sonatype.org/ >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Flex Mojos" group. >>> To post to this group, send email to [email protected] >>> To unsubscribe from this group, send email to >>> [email protected]<flex-mojos%[email protected]> >>> For more options, visit this group at >>> http://groups.google.com/group/flex-mojos >>> >>> http://flexmojos.sonatype.org/ >>> >> >> -- >> You received this message because you are subscribed to the Google >> Groups "Flex Mojos" group. >> To post to this group, send email to [email protected] >> To unsubscribe from this group, send email to >> [email protected]<flex-mojos%[email protected]> >> For more options, visit this group at >> http://groups.google.com/group/flex-mojos >> >> http://flexmojos.sonatype.org/ >> > > -- > You received this message because you are subscribed to the Google > Groups "Flex Mojos" group. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected]<flex-mojos%[email protected]> > For more options, visit this group at > http://groups.google.com/group/flex-mojos > > http://flexmojos.sonatype.org/ > -- You received this message because you are subscribed to the Google Groups "Flex Mojos" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/flex-mojos http://flexmojos.sonatype.org/
