Hi there,

The TODO says:
Multiple backups launched within the same second clobber each other's

Likewise, the comment for current_time() says:
# Return current time in ctime format if normal
# in YYYYMMDDHHMM.SS format if 'numeric' is given

In fact, for stock 1_2_1, the second is omitted from e.g. file names, and so the problem from the TODO is really that all backups launched within the same minute have the same names.

Here is a patch so it will behave as documented. Alternatively, we
should patch current_time()'s comment and the comment in the TODO. (Less


Peter Valdemar Mørch
Index: flexbackup
RCS file: /cvsroot/flexbackup/flexbackup/flexbackup,v
retrieving revision 1.185
diff -u -w -r1.185 flexbackup
--- flexbackup  10 Oct 2003 14:12:09 -0000      1.185
+++ flexbackup  28 Jul 2006 12:57:17 -0000
@@ -3687,7 +3687,7 @@
     my $current_time = time;
     if (defined($format) and ($format eq 'numeric')) {
-       $string = strftime("%Y%m%d%H%M", localtime($current_time));
+       $string = strftime("%Y%m%d%H%M.%S", localtime($current_time));
     } elsif (defined($format) and ($format eq 'ctime')) {
        $string = strftime("%a %b %d %H:%M:%S %Y", localtime($current_time));
     } else {
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
flexbackup-help mailing list

Reply via email to