Well, there was a Homer "Doh!!" moment when I realized there was no code to detect which save button had been pressed. No wonder we were both going around in circles. This started as a Null Edit bug, but the hard part was recognizing that there was another bug also present.
I do hope this patch is better. The major benefit of all this is now I know I can contribute to a reworking of the Web App if it is decided to do so. John Davidson On 7/18/07, Jimmy Sieben <[EMAIL PROTECTED]> wrote:
FWIW, I have never understood Save vs Save and Back, and every time I click on the button it doesn't do what I think it should do. *From:* [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] *On Behalf Of *Craig Andera *Sent:* Wednesday, July 18, 2007 2:17 PM *To:* 'FlexWiki Users Mailing List' *Subject:* Re: [Flexwiki-users] NullEdit in WikiEdit.aspx.cs Hmm. After applying this patch, I notice that clicking on a non-existent topic, making an edit, and then clicking "Save" still takes me back to the page I came from. But perhaps I'm confused about what that button should do. *From:* [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] *On Behalf Of *John Davidson *Sent:* Tuesday, July 17, 2007 8:52 PM *To:* FlexWiki Users Mailing List *Subject:* Re: [Flexwiki-users] NullEdit in WikiEdit.aspx.cs This is a slightly different version of the patch. There are only 3 lines actually changed from the prior patch, but I wasn't sure of the impact of doing a Merge first. I did not understand how the "Save and Back" button worked. Now that you have explained I believe I now have the page doing everything it should again with respect to null edit and edits from a non-existent topic link. John Davidson On 7/17/07, *Craig Andera* <[EMAIL PROTECTED]> wrote: OK, I applied this patch and I notice two things: 1) The "Save and Back" button appears even when I'm editing the page not via a link. E.g. I double-click the page. This appears to be the difference between the Topic and ReturnTo query string parameters. 2) The "Save and Back" button doesn't actually take me back when I visit the edit page via a link to a nonexistent topic. I realize that these bugs are very likely ones that I introduced, but as long as you're working on this area I wonder if you'd mind fixing that stuff up too? Pretty please? J I'll go look at the other patch now. *From:* [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] *On Behalf Of *John Davidson *Sent:* Friday, July 13, 2007 8:08 PM *To:* FlexWiki Users Mailing List *Subject:* [Flexwiki-users] NullEdit in WikiEdit.aspx.cs Hi Craig Here is an alternate patch for the NullEdit bug identified about 2 weeks ago. When you fixed it you also seemed to have caused a side-effect that when creating a new topic from a link on a page, when you save the new topic, you return to the page where the link was rather than going to the newly created topic page. For consideration John Davidson ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Flexwiki-users mailing list Flexwiki-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flexwiki-users ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Flexwiki-users mailing list Flexwiki-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flexwiki-users
NullEdit_WikiEdit_aspx_cs.patch
Description: Binary data
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Flexwiki-users mailing list Flexwiki-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flexwiki-users
