I changed this to
If (!string.IsNullOrEmpty(stringTopic))
instead. No biggie.
The other thing I noticed is that this code still contains references to
DateTime.Now. Because of the indeterminism introduced when testing, I
removed all the references I could find to DateTime.Now and replaced them
with Federation.TimeProvider.Now instead. The default ITimeProvider is just
DateTime, but during unit tests we use something more deterministic
(MockTimeProvider). In this case, there's no Federation instance handy to do
this with, so I left it. Not much to be done here without some rework, but I
thought it might be good to make other devs aware of this change.
I also reordered the methods further, as some of them appeared before the
properties. Again, no biggie.
Anyway, another solid patch from John, thanks! Committed - should show up in
build 66. Sorry it's taken me so long to get to it. On to the others.
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of John
Davidson
Sent: Sunday, July 22, 2007 7:31 AM
To: FlexWiki Users Mailing List
Subject: Re: [Flexwiki-users] TopicIndexBehavior Patches
The 2 versions of the patch witha much better construct instead of that in
the first
if ((!(stringTopic == null)) && (stringTopic > 0)) -> if ((stringTopic !=
null) && (stringTopic > 0))
John Davidson
On 7/21/07, Craig Andera <[EMAIL PROTECTED]> wrote:
Wow - great! I'll see if I can find time to review/integrate these this
weekend, but it'll probably be Monday.
Thanks!
From: [EMAIL PROTECTED]
<mailto:[EMAIL PROTECTED]>
[mailto:[EMAIL PROTECTED] On Behalf Of John
Davidson
Sent: Saturday, July 21, 2007 7:56 AM
To: FlexWiki Users Mailing List
Subject: [Flexwiki-users] TopicIndexBehavior Patches
These are 2 candidate patches for bug #1758087. It was easier to track down
than I thought it might be as I had never looked in that section before.
https://sourceforge.net/tracker/?func=detail
<https://sourceforge.net/tracker/?func=detail&atid=665396&aid=1758087&group_
id=113273> &atid=665396&aid=1758087&group_id=113273
The first patch is for functionality only and changes to lines of code. the
larger patch is to bring the ClassicBehaviors.cs file up to current
standards
John Davidson
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Flexwiki-users mailing list
Flexwiki-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flexwiki-users
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Flexwiki-users mailing list
Flexwiki-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flexwiki-users
