Committed and bug closed. Thanks again!
Since you've been doing such good work, we've gone ahead and granted you
commit access to the Subversion repository. You're now armed and dangerous.
:)
Some general comments to all committers:
----------------------------------------------------
All committers are encouraged to solicit the review of other committers or
the community in general before committing patches. We generally require
that changes be accompanied by corresponding unit tests with coverage of
100% being the goal; that code correspond to project coding guidelines; and
that every commit correspond to at least one (ideally one) SourceForge work
item (RFE or bug). Comments in this form [1] make the change history page
[2] easy to read and easy to use when writing release notes, so please use
this format. Detailed comments can be recorded in the corresponding BUG/RFE.
[1]
* BUG 1234567 - Title of bug 1234567
* RFE 7654321 - Title of RFE 7654321
[2]
http://builds.flexwiki.com/builds/ChangeHistory.ashx?Project=FlexWikiCore-20
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of John
Davidson
Sent: Sunday, July 22, 2007 3:25 PM
To: FlexWiki Users Mailing List
Subject: [Flexwiki-users] Bug 1667628 LinkToSearchFor
Hi Craig,
Here is another candidate patch. This time for #1667628 LinkToSearchFor with
Namespace. Code adds a check for a null Namespace in the LinkMaker function
and outputs correct html for the search terms whether there are one or two
terms included. Also encoded the Namespace when it is used to prevent
injection attacks and made the second term prefix, which was '?', into
'&'
You can test the condition using the Find references border function first
without a namespace and then by substituting a valid namespace name for the
'null' in the LinkToSearchFor arguments.
John Davidson
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Flexwiki-users mailing list
Flexwiki-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flexwiki-users
