Excellent stuff. Thanks John. I'll pick up your changes when they're
submitted, and amend the default stylesheet accordingly.
You're absolutely right on the style vs. ID argument, though. We should keep
those kind of changes in. For things like the borders, it would make sense
to define a .Border class and have IDs of top, bottom, left, and right, so
that consistent styling can be applied if required.
Derek.
On 8/6/07, John Davidson <[EMAIL PROTECTED]> wrote:
>
> I knew you were making changes to the css, that is why I felt I needed
> your input. I chose the ID because because these elements occur a
> maximum of once. This is when a stylesheet should reference the ID
> instead of a class, which is used for an element that occurs many
> times.
>
> I will check in the changes including a css 'wiki_jwd.css' that I
> currently use as an override.
>
> First I need to see if there is a bug report or feature request on
> XHTML functionality and if not I will create one, then do the checkin.
> Should be completed within the next hour
>
> John Davidson
>
> On 8/6/07, Derek Lakin <[EMAIL PROTECTED]> wrote:
> > Having just exchanged a few comments with Craig about the new CSS
> stylesheet
> > that I'm working on for FW 2.0 has reminded me that if you change from
> using
> > class to ID for the styling "hook" then that will completely mess up my
> > stylesheet.
> >
> > That said, if you've changed the source (X)HTML and layout, then the
> > stylesheet will most likely need to change anyway. What we really need
> is
> > your changes checked in ASAP so that the rest of us can play, too :o)
> >
> > Derek.
> >
> >
> > On 8/6/07, Craig Andera <[EMAIL PROTECTED]> wrote:
> > > > It would be fantastic if you could check in your changes. That would
> > > > give
> > > > people a way to install your changes on their wikis to see the
> results,
> > > > but
> > > > more importantly :) it would let me run my perf tests with your
> > > > alterations!
> > > > Also, it's easier to integrate frequent small commits.
> > >
> > > OK, guess we need to wait for Derek to finish the CC.NET upgrade
> first. :)
> > >
> > > Actually, if you can send me a patch offline, that would be great -
> I'm
> > > hoping to do another round of benchmarking today.
> > >
> > >
> > >
> > >
> >
> -------------------------------------------------------------------------
> > > This SF.net email is sponsored by: Splunk Inc.
> > > Still grepping through log files to find problems? Stop.
> > > Now Search log events and configuration files using AJAX and a
> browser.
> > > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > > _______________________________________________
> > > Flexwiki-users mailing list
> > > Flexwiki-users@lists.sourceforge.net
> > >
> > https://lists.sourceforge.net/lists/listinfo/flexwiki-users
> > >
> >
> >
> >
> -------------------------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc.
> > Still grepping through log files to find problems? Stop.
> > Now Search log events and configuration files using AJAX and a browser.
> > Download your FREE copy of Splunk now >> http://get.splunk.com/
> > _______________________________________________
> > Flexwiki-users mailing list
> > Flexwiki-users@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/flexwiki-users
> >
> >
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems? Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> Flexwiki-users mailing list
> Flexwiki-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/flexwiki-users
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Flexwiki-users mailing list
Flexwiki-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flexwiki-users
