> 1) Give the edit box focus on the edit page. I didn't try to make it > do anything special, just give it focus.
Great! I love it. > 2) Added some tests to prevent the user from creating Topics that are > otherwise unusable by the system. (So, no dashes '-' no slashes of any > sort '/' or '\').. I reused the regex used by the formatter, so if the > Formatter can't parse it to render it, then you are no longer able to > create it. I decided that this was better than allowing people to > create links that they couldn't get to or would cause exceptions > deeper in the engine. So, this is an interesting idea. One of the things that's problematic is that there are several ideas of a topic name sprinkled around the system. I tried to clean it up in the core by introducing TopicName as the ultimate arbiter, but of course you point out that Formatter has its own idea. One issue I can see is that there are many ways to create a topic other than the web app. There's the web service, for example, and of course people can just throw files into the filesystem. In that last case, I don't think it's a big deal if the engine blows chunks - if you're going to screw around in the directory you get what you deserve. Of course, we don't want to blow up on anything that someone could legally have created under 1.8, because it could lead to a confusing upgrade situation. One issue that I'm not 100% sure how to address is when someone makes a ton of links like [illegal-name] and then clicks to try to create. I can see three ways to deal with this: 1) Fail when they click to try to create. 2) Display a warning at the site of the link (popup or when the page with the link is submitted) 3) Use escaping to make any name legal (e.g. encode illegal-name as illegal%3fname or something). These are arranged in order of difficulty, I think. In short, I don't think it's a terrible thing to restrict the topic names people can create *somewhat*. Disallowing slashes and dots, for example, is good. I think it's great to give them a friendly error message that says what's wrong. But I think we generally have to follow Postel's Law [1] and try to be conservative in what we produce and liberal in what we accept. In other words, while it's reasonable to block someone from creating a new topic with an illegal name, we better be prepared to let them edit one if it already exists. [1] http://en.wikipedia.org/wiki/Robustness_Principle ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Flexwiki-users mailing list Flexwiki-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flexwiki-users
