On 5 Nov 2012, at 13:04, Flightgear-commitlogs wrote: > - Log ----------------------------------------------------------------- > commit 186bae2bd445f16540a66e23e81c307c194cf721 > Author: Thomas Geymayer > Date: Mon Nov 5 13:35:06 2012 +0100 > > Proper headless build fix > > > - Summary ------------------------------------------------------------- > > simgear/misc/parse_color.cxx | 4 ++++ > simgear/misc/parse_color.hxx | 6 +----- > 2 files changed, 5 insertions(+), 5 deletions(-)
This is still not ideal: the goal is to have no #ifdefs, because we simply partition the files based on requiring OSG. So if this header file needs OSG, it should be in some other location than misc; probably some sensible subdirectory of 'scene'. Ifdefs are bad because they change the contents of the SimGearCore library - ideally building headless or not, should make no difference at all to the SimGearCore library that is produced. Regards, James ------------------------------------------------------------------------------ LogMeIn Central: Instant, anywhere, Remote PC access and management. Stay in control, update software, and manage PCs from one command center Diagnose problems and improve visibility into emerging IT issues Automate, monitor and manage. Do more in less time with Central http://p.sf.net/sfu/logmein12331_d2d _______________________________________________ Flightgear-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/flightgear-devel
