Cameron Moore wrote:
>
> * [EMAIL PROTECTED] (Curtis L. Olson) [2002.03.21 08:58]:
> > Index: panel_io.cxx
> > ===================================================================
> > RCS file: /var/cvs/FlightGear-0.7/FlightGear/src/Cockpit/panel_io.cxx,v
> > retrieving revision 1.36
> > retrieving revision 1.37
> > diff -C2 -r1.36 -r1.37
> > *** panel_io.cxx 19 Mar 2002 16:12:15 -0000 1.36
> > --- panel_io.cxx 20 Mar 2002 14:57:31 -0000 1.37
> > ***************
> > *** 296,300 ****
> > }
> >
> > ! if (propName != "") {
> > target = fgGetNode(propName.c_str(), true);
> > }
> > --- 296,300 ----
> > }
> >
> > ! if (propName != (string)"") {
> > target = fgGetNode(propName.c_str(), true);
> > }
>
> As Bernie has mentioned before[1], this should be:
>
> if (!propName.empty()) {
>
> And for someone who has time, there's plenty more of these to be fixed:
>
> $ cd FlightGear/src/
> $ find . -type f -name '*.[ch]??' | xargs grep -n '[=!]= ""'
> ./ATC/ATCmgr.cxx:112: if(last_comm1_ident != "") {
[snip]
Just to make life more complicated, the latest changes to the property
system return const char* instead of std::string. Don't know if it will
have any impact on this todo item.
Bernie
_______________________________________________
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel
