David Megginson <[EMAIL PROTECTED]> said: > It's a bad one for inlining, actually, because that forces globals.hxx > to have a dependency on viewmgr.hxx, so all of FlightGear has to > rebuild whenever Jim touches the viewer code. > > What we should do is find out why get_current_view is called so much > -- almost no other part of FlightGear should care about it. Jim's > already started uncoupling things, and we can look to see if it's used > in a loop somewhere (where it could be assigned to a variable just > once).
I think we'll weed some of these things out when we start implementing that FGLocus class (or whaterver it is called). It's hard to fix some of this stuff until the uncoupling is completed. When I get done viewer is only going to know about the view and nothing else. 54 times per frame is almost unbelievable considering the number of references to viewer data, so as David suggested a good start would probably be moving it to a variable. BTW IIRC that returns a pointer to the class...I think I remember seeing the code that was doing that over and over...maybe tilemgr? Best, Jim _______________________________________________ Flightgear-devel mailing list [EMAIL PROTECTED] http://mail.flightgear.org/mailman/listinfo/flightgear-devel
