I have FlightGear building without warnings under MSVC, with the following exceptions:
FDM/ExternalNet.cxx has two byte-order conversion on bool. What size is bool? I know, I could instrument the code, but it is getting late. FDM/UIUCModel/uiuc_menu.cpp: the check_float() function doesn't look right, to me. FDM/LaRCSim/ls_model.c has some symbols that need to be added to a header, somewhere. Cockpit/hud.hxx defines NONE as a macro. Could the #defines in there be made into enumerations? Aside from removing unreferenced variables, the bulk of the changes were in the area of the use of floating-point. Since C does all passing of floats as doubles, and does all math in double, could we have a mandate that all floating-point valued be double? I can see it being a pain for the programmer to always add the 'f' at the end of float constants, just go get around the compiler warnings. While on the subject of floating-point, I will get on one of my soap boxes. Taking 5/2.0 may not always yield the result you intend. I would suggest using 5.0/2.0 or, if you really want the integer result, floor(5.0/ 2.0) and ceil(5.0/2.0). Another personal nit is the lack of a leading zero on numbers < 1.0 (I prefer seeing 0.5 rather than .5). Is there a general preference for FlightGear? Jonathan Polley _______________________________________________ Flightgear-devel mailing list [EMAIL PROTECTED] http://mail.flightgear.org/mailman/listinfo/flightgear-devel
