Alex Romosan writes:
> 
> "Norman Vine" <[EMAIL PROTECTED]> writes:
> 
> > Doesn't SGPath.apapend just do the right thing here ? 
> >
> > i.e. there shouldn't be a need to do the
> >
> >> ! #ifdef _MSC_VER
> >> !             tmp.append( ";");
> >> ! #else
> >> !             tmp.append( ":");
> >> ! #endif
> >
> > kludge in the patch below
> >
> > if append() doesn't do the right thing I suggest we would be
> > better off fixing append() rather then kludging every instance 
> > of it use.
> 
> we should use sgDirPathSep instead. it's defined in
> simgear/misc/sg_path.cxx, but it should be moved to the header file
> instead so it can be used elsewhere.

Agreed but ....
append() should/will just do this automagically  :-)

// append another piece to the existing path
void SGPath::append( const string& p ) {
    if ( path.size() == 0 ) {
        path = p;
    } else {
        if ( p[0] != sgDirPathSep ) {
            path += sgDirPathSep;
        }
        path += p;
    }
    fix();
}

Cheers

Norman

_______________________________________________
Flightgear-devel mailing list
[EMAIL PROTECTED]
http://mail.flightgear.org/mailman/listinfo/flightgear-devel

Reply via email to