Sorry about the late comment:
1) I do not understand lines like that
#ifdef HAVE_CONFIG_H
# include <config.h>
#endif
in Simgear (math/sg_geometry.h) since the config file from Simgear is simgear_config.h
2) The pthread-win32 library, needed for Windos do contain the same thre lines of code.
#ifdef HAVE_CONFIG_H
# include <config.h>
#endif
Its ugly to work around the different config files in 3rdparty libraries.
Olaf
2006/2/18, Melchior FRANZ <[EMAIL PROTECTED]>:
* Frederic Bouvier -- Saturday 18 February 2006 16:29:
> Modified Files:
> voice.cxx
> Log Message:
> Not missing but at the wrong place
Ah, OK. (Normally, one should keep #includes away from header
files as much as possible, but as class definitions contain short
code parts, this CONFIG_H is better put there. So I'd rather
prefer to not have it in voice.cxx again, if it has no meaning
anyway.)
But frankly, I don't get this noise in all files:
#ifdef HAVE_CONFIG_H
# include <config.h>
#endif
Why the #ifdef? Is there a reasonable case where CONFIG_H is
*not* available? Isn't it created by the build system? Doesn't
its absence tell us that something went very wrong? So why do
we even think about compiling files without it?
And *iff* it can be missing in some relevant case. Why don't we
have a much saner file fgfs.h that is to be included everywhere
*instead*, which contains just:
/* fgfs.h */
#ifdef HAVE_CONFIG_H
# include <config.h>
#endif
m.
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
