What needs to be changed/fixed/rewritten/redesigned(!) before it can be applied to the main CVS version?
Hugo.
On 4/25/06,
Hugo Vincent <[EMAIL PROTECTED]> wrote:
Thanks Erik,
Here is the patch. Let me know what needs to be changed, fixed, or
refactored before it can go into CVS. Note that at this point, the
binary protocol is output only.
Also attached is a really simple protocol to test the patch
(bintest.xml). Run FGFS with:
$ fgfs ... --generic=file,out,24,bintest_out,bintest
As well, there is a Python script (sorry, the script is a horribly dirty
hack) to decode and print the results. Execute it with:
$ python test_decode.py
To do list for the generic binary support:
* use ntohl() etc to make the protocol independent of host endianess.
* add CRC checksum as a possible packet footer
* add binary input support
* test thoroughly
Cheers,
Hugo Vincent
On Mon, 2006-04-24 at 09:59 +0200, Erik Hofman wrote:
> Hugo Vincent wrote:
>
> > I also updated OpenGC for this change and made a OpenGC.xml protocol
> > file, but it appears the OpenGC project is more or less dead. Also,
> > Network/opengc.cxx is a bit of a mess and seemingly unmaintained; it
> > might be nice to get rid of it and replace it with a XML file at some
> > stage. One approach is to directly replace opengc.cxx with an XML file
> > that emulates the structure of the ogcFGData class, - however different
> > compilers probably pad the variables in the class differently (for
> > alignment/efficiency), so a patch to OpenGC does need to be made.
> >
> > If anyone wants the generic binary mode patch, or better yet, wants to
> > add it into the main FlightGear repository, reply (to the list).
> >
> > Also, if anyone else has uses or requirements for binary protocols, let
> > discuss them here, so that we can make generic binary support as broad
> > and applicable as possible.
>
> I think it would be valuable, exactly for the reason mentioned above.
>
> Erik
>
>
