Melchior, On Feb 2, 2007, at 2:18 AM, Melchior FRANZ wrote: > * Tatsuhiro Nishioka -- Friday 02 February 2007: >> Actually the canopy of J7W is temporal for now so opening/closing >> canopy is not implemented yet. > > I know that the canopy isn't animated yet. But seeing how you > intended to do it in the Nasal code was reason enough to fix > it already.
Ah, it doesn't mean I don't have to fix it, but means I should implement the canopy soon. And I'm really glad to know a better way. Thanks for that. > Only after that I noticed that you copied it from > the Ki-84, where you copied it from the A6M2. Bad Nasal code > is spreading like wildfire. :-} Yes, I'm also worried about putting code spreading all over the place in CVS. It's no good. I included the same code since each archived file should be independent from others that are not included in the base package. The problem here is that I should have not given the package to you as it was. I should have known what I should do and I should not do before that. I'm very happy to cooperate with the architectural conventions or rules if you share these with me (or us). we've discussed this issue a bit so I understand a little about what you have. so could you tell us what else you have in your mind about the conventions, or tell us what documents should we look at? If I get it right, it can be "Do not copy the same Nasal code from other aircraft." By the way, requiring other aircraft only for Nasal code is lacking of usability especially in the case none of the aircraft that share the similar code is included in the base package. That's why I'm using the same code in the different aircraft even though I know these are redundant when installed. As many aircraft are distributed as independent archive packages, these should work when installed, thus the common code should be included. Otherwise the dependencies should be resolved when installed. However, this reason is only for myself and does not excuse what I have done. > >> I'll also try to find a way to avoid the Nasal error. It should >> happen in Ki-84 and A6M2 too, maybe only on CVS version. >> And I guess this is why fdm_initialized signal is introduced in CVS >> version, right? > > Exactly. And it *should* be used. Don't try to avoid it just to > make your aircraft compatible with old versions. CVS/HEAD is for > the *next* release, not the last one. Okay, I understand another convention. "Do not write any code only for the backward-compatibility reason." I'll fix this immediately. >> Though it's a bit redundant in CVS version but It works on both >> versions. > > Argh. I don't want bad & obsolete code in CVS/HEAD just to keep > compatibility with old fgfs version. That's not what CVS/HEAD is > for. It needs to develop and become better, not be frozen. I only > made the Ki-84 COMPAT_0_9_10 branchlet because it was assumed > that the removal of redundant key bindings was the only thing > that broke it for 0.9.10. But now I'm sorry I did, as this > obviously leads in the wrong direction. I think about removing it > again. You don't have to make yourself confused by doing so. Just let me make it better. I'll clean up the code for CVS-HEAD and give these to you when done. At this moment, for CVS-HEAD, I will clean up the code by: - including A6M2/electrical.nas from each -set.xml for both Ki-84 and J7W. - using fdm_initialized singal to start the updates() func. - removing the code that exists only for the backward-compatibility reason. How's this? If there's any conventions or rules that you have, Please have these posted here. Tat ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
