On Saturday 03 March 2007 08:31, Melchior FRANZ wrote:
> I don't think it can be applied as it is. I'm no physicist and
> can't comment on the logic, but there are some formal aspects
> to fix IMHO:
>
> atmo.?xx:
>
> - code on the top level must not be indented
> - proper indentation everywhere (Frankly, 2 spaces aren't enough
> for my taste. They produce visual spaghetti code.)
I'll add:
There is a mixture of tabs and spaces here too.
> - comments in a block shall be indented aligned with the block,
> not begin in column 0
> - if (a_tvs_p) delete a_tvs_p; shall be just delete a_tvs_p;
> - cout/cerr must not be used (use SG_LOG with proper log level)
I believe that MSVC needs the iterator to be declared before the loop:
int i;
for (i = 0; ; i++)
> - for (int ii = 0; ; ii++) shall be for (int i = 0; ; i++)
> - don't add empty *and* commented out class definitions
>
> altimeter.cxx:
>
> - don't introduce tab indentation in a file that uses 4 spaces
> - if qqq stands for "quantum, then call it quantum:
> Altimeter::Altimeter ( SGPropertyNode *node, const double qqq)
If qqq is going to default to 10 (from instrument_mgr.cxx: new Altimeter(
node , 10)), I think we can just drop it all together and put
_quantum(node->getDoubleValue("quantum", 10)) in altimeter.cxx.
--
Roy Vegard Ovesen
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
