On Sun, 2007-02-11 at 20:27 -0600, Jon S. Berndt wrote:
> >     1.24 Misdirected diagnostic in JSBSim.cxx
> 
> Was the fix for this applied to JSBSim.cxx in JSBSim CVS, too?
> 
> Jon

The wiki [1] says this bug is fixed in JSBSim, however that is not true.
CVS for flightgear [2] matches CVS for JSBSim [3] and both still contain
the code for dumping the error code to cout.

I don't speak C++, but would this patch be an acceptable fix?

Index: JSBSim.cxx
===================================================================
RCS file: /var/cvs/FlightGear-0.9/source/src/FDM/JSBSim/JSBSim.cxx,v
retrieving revision 1.41
diff -u -r1.41 JSBSim.cxx
--- JSBSim.cxx  19 Mar 2007 16:37:36 -0000      1.41
+++ JSBSim.cxx  31 Mar 2007 23:48:55 -0000
@@ -425,10 +425,14 @@
     if (!cache_ok) {
       SG_LOG(SG_FLIGHT, SG_WARN,
              "FGInterface is being called without scenery below the 
aircraft!");
-      cout << "altitude         = " << alt << endl;
-      cout << "sea level radius = " << slr << endl;
-      cout << "latitude         = " << lat << endl;
-      cout << "longitude        = " << lon << endl;
+      SG_LOG(SG_FLIGHT, SG_WARN,
+             "altitude         = " << alt);
+      SG_LOG(SG_FLIGHT, SG_WARN,
+            "sea level radius = " << slr);
+      SG_LOG(SG_FLIGHT, SG_WARN,
+            "latitude         = " << lat);
+      SG_LOG(SG_FLIGHT, SG_WARN,
+            "longitude        = " << lon);
       //return;
     }




[1] 
http://wiki.flightgear.org/flightgear_wiki/index.php?title=Bugs#Misdirected_diagnostic_in_JSBSim.cxx
[2] 
http://cvs.flightgear.org/cgi-bin/viewvc/viewvc.cgi/source/src/FDM/JSBSim/JSBSim.cxx?annotate=1.41
 lines 428-431
[3] 
http://jsbsim.cvs.sourceforge.net/jsbsim/JSBSim/src/JSBSim.cxx?revision=1.13&view=markup
 lines 428-431


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to