Stuart Buchanan

> Sent: 05 December 2007 08:19
> To: FlightGear Dev
> Subject: [Flightgear-devel] Chat Menu and fix for chat repetition bug
> 
> 
> Hi All,
> 
> The latest and greatest chat menu system is now available. I 
> have added a couple of new features and fixed a number of bugs:
> 
> - The chat menu automagically creates messages that include 
> the nearest airport, the current runway in use (based on the 
> current weather conditions), and information about your 
> aircraft and location. For example "Half Moon Bay Traffic, 
> G-FGFS is type Cessna, inbound from the south-west at 
> 4,000ft, straight in approach runway 30, 4 miles to run". 
> - The chat repetition bug should now be completely fixed 
> (though I have only seen it twice, so I can't be 100% certain).
> - Going backwards and forwards through the message tree is 
> now more reliable.
> 
> The patch consists of a number of files (from
> http://www.nanjika.co.uk/flightgear/chatmenu.tar.gz):
> - multiplayer.nas: a complete replacement for Nasal/multiplayer.nas
> - chat-menu.xml: a new dialog to be placed under gui/dialogs
> - chat-menu-entries: an XML file defining the various chat 
> messages, based on CAP-143 (UK standard radio phraseology). 
> To be placed under ATC/
> 
> The patch also changes a small number of other files, for 
> which diffs are included below.
> 
> As Melchior doesn't spend much time using Multiplayer, he has 
> asked that I post to the list, so someone with more MP 
> experience can review and commit it to CVS.
> 
> I think this is a big improvement over the current broken 
> chat implementation and improves the MP experience 
> significantly. I'd therefore ideally like it to be included 
> in the release. As the patch is non-trivial, I'd appreciate 
> it if it could be committed so that plenty of people can have 
> the chance to try it out before the release.
> 
> Thanks
> 
> -Stuart
> 
> Index: preferences.xml 
> ===================================================================
> RCS file: /var/cvs/FlightGear-0.9/data/preferences.xml,v
> retrieving revision 1.256
> diff -u -r1.256 preferences.xml
> --- preferences.xml   4 Dec 2007 13:12:15 -0000       1.256
> +++ preferences.xml   5 Dec 2007 07:58:48 -0000
> @@ -472,6 +472,7 @@
>     <chat type="string">Hello</chat>
>     <transmission-freq-hz 
> type="string">118500000</transmission-freq-hz>
>     <chat-display type="bool" userarchive="y">true</chat-display>
> +   <chat-menu include="ATC/chat-menu-entries.xml"/>
>    </multiplay>
>  
>    <user>
> 
> Index: menubar.xml 
> ===================================================================
> RCS file: /var/cvs/FlightGear-0.9/data/gui/menubar.xml,v
> retrieving revision 1.68
> diff -u -r1.68 menubar.xml
> --- menubar.xml       4 Dec 2007 10:51:45 -0000       1.68
> +++ menubar.xml       5 Dec 2007 07:57:44 -0000
> @@ -162,6 +162,14 @@
>     </binding>
>    </item>
>  
> +  <item>
> +   <label>Chat Menu</label>
> +   <binding>
> +    <command>dialog-show</command>
> +    <dialog-name>chat-menu</dialog-name>
> +   </binding>
> +  </item>
> +
>   </menu>
>  
>   <menu>
> 
> Index: keyboard.xml 
> ===================================================================
> RCS file: /var/cvs/FlightGear-0.9/data/keyboard.xml,v
> retrieving revision 1.103
> diff -u -r1.103 keyboard.xml
> --- keyboard.xml      26 Nov 2007 17:55:28 -0000      1.103
> +++ keyboard.xml      1 Dec 2007 10:08:51 -0000
> @@ -352,7 +352,17 @@
>    </mod-up>
>   </key>
>  
> - <key n="46">
> +  <key n="45">
> +    <name>-</name>
> +    <repeatable type="bool">false</repeatable>
> +    <desc>Compose Chat</desc>
> +    <binding>
> +       <command>dialog-show</command>
> +       <dialog-name>chat-menu</dialog-name>
> +    </binding>
> +  </key>
> +
> +  <key n="46">
>    <name>.</name>
>    <desc>Right brake</desc>
>    <binding>
> @@ -773,6 +783,16 @@
>    </mod-up>
>   </key>
>  
> +  <key n="95">
> +    <name>_</name>
> +    <repeatable type="bool">false</repeatable>
> +    <desc>Compose Chat</desc>
> +    <binding>
> +      <command>nasal</command>
> +      <script>multiplayer.compose_message()</script>
> +    </binding>
> +  </key>
> +
>   <key n="97">
>    <name>a</name>
>    <desc>Increase speed-up.</desc>
> 
> 

I've tested this all with Start, and after some changes and bug fixes it is
now in cvs-head. Unfortunately, my cvs client has crashed, and I can't
backport it to plib until tomorrow.

Vivian



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to