Tiago Gusmão wrote > Subject: [Flightgear-devel] XML Particles patch > > > Hi > > Here's the patch to add particles by XML to the OSG branch > (instructions > inside): > http://gusmao.home.sapo.pt/particlesv1.tar.gz > (that page is not an error, you will have to click in "AQUI", > because it > doesn't like hotlinking much) > > There is a short document here: > http://gusmao.home.sapo.pt/README.xmlparticles > > A few problems and limitations are known: > The deletion of at least some of the objects seems not to > work, the xml parsing code really gets boring, so not everything is > configurable or property-driven at the moment > There shouldn't be any significant changes in the future in > the existing > XML spec, but i don't promise anything! > Default values aren't yet established >
Nice work so far. Just a few comments: Gravity/buoyancy appear to be non op. Wind has some effect, but not what I would expect (hmm might still be using the osg wind?). Fluid effects work, at least for air, but I'm not absolutely sure they are correct. Size is broken in this patch, but fixed with Tiago's help locally. The XML is a bit of a mess - It doesn't seem always adhere to our (de facto) convention of including the units in the tag: <x-m>, <pitch-deg>, but <mass>, <radius> etc <maxx>, <maxy> etc, but elsewhere in animations we use <x-max> <y-min>. <maxtheta> etc. in radians - AFAIK this is the only use of radians in models - everywhere else is in degrees (including within particles). This look and feel issue is important because the XML is intended to be included in the Model file along with other animations where the difference in conventions is going to lead to confusion, mistakes, and frustration. It's only a few minutes work to get this right before we have all written too many particle animations to make change easy. I'll do it for you if you like. Despite all this, particles work and work well: I have been able to recreate the existing smoke effects in the Buccaneer relatively easily. The cost in frame rate is a little disappointing here, but I hope this can be improved. Well done Tiago, we have been waiting a long time for this! Vivian ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Flightgear-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/flightgear-devel
