* Frederic Bouvier -- 11/2/2008 10:45 AM:
> Patch from Nicolas Vivien : don't pour rain above cloud layers,
> turn rain into snow when temperature is below 0°C
>
> Index: precipitation_mgr.cxx
That's the wrong place for such logic. This belongs into fg_metar.cxx,
which is meant to prepare METAR data (sg_metar.cxx) for FlightGear
consumption. If the precipitation module is told to show rain,
then it should do just that. Spreading out the logic to several
files is messy.
Can we please *not* uglify fg/sg source code with such obvious
comments?!
> + // Convert the result in meter
> + result = result * SG_FEET_TO_METER;
Oh, really?! This converts FEET TO METER?
> + // Does the user enable the precipitation ?
> + if (!sgEnviro.get_precipitation_enable_state()) {
> + // Disable precipitations
Oh, "if enabled" means to ask whether it's enabled?
> + // Update the drawing...
> + precipitation->update();
Oh, "update" means ... update?
> + // Exit
> + return;
Pfft ...
Anyone paid for the number of lines put into CVS? :-}
m.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Flightgear-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
