Hi,
On Sun, Nov 30, 2008 at 12:56 AM, Tim Moore <[EMAIL PROTECTED]> wrote:

> Yon Uriarte wrote:
> > Hi,
> >
> > On Sat, Nov 29, 2008 at 1:41 AM, Tim Moore <[EMAIL PROTECTED]
> > <mailto:[EMAIL PROTECTED]>> wrote:
> >
> >     Yon Uriarte wrote:
> >      > Hi,
> >
> >      > logstream.cxx:
> >      >     Modified a bit the logstream implementation to avoid (stack)
> >     descent
> >      > down into (iostream) hell if we are not logging anything anyway.
> >     As it
> >      > is right now, it happily builds the string to print (iostream
> >     hell, deep
> >      > stacks, strings new/delete/copy) and then discards it. I´ve
> >     counted over
> >      > half a million calls to sglog() before the scenery is fully
> >     loaded (cant
> >      > remember with what configuration, more on config below).
> >      >     Also, the global logstream is initialized once at startup
> >      > (constructors, struct ignore_me), no need to check everytime it is
> >      > called if it's initialized. Maybe if sglog() is used in any global
> >      > constructor it could happen that it is not initialized and crash,
> so
> >      > please, dont use it in the global constructors ;)
> >     I've reworked the logstream changes a bit and checked this in.
> Thanks.
> >
> >
> > Nice. It is still doing a pointless function call.
> No. Your request to "don't use it in the global constructors" is not
> sufficient.
>

Shouldnt matter too much performance wise anyway :)

I attach the patch for the airport, airway and navdb loaders. Also included
is the patch to throttle the frame rate while loading the scenery at startup
and to set the gzip input buffer to 64k (was 4k).
I believe all of them make sense and are sufficient. I'd like to ask for
them to get tested and eventually applied. I'll keep resubmiting them at 1
week intervals :)


greetings,
 yon

Attachment: loader.patch.rar
Description: Binary data

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to