Two people in the forum offered to commit this tanker stuff.
Don't! The idea is great, but it's not in committable shape
yet!
- inacceptable dependency on scenarios (for no good reason)
- four dialogs only to ask for one tanker?
- badly laid out dialogs; no reasonable default values filled in
- bad Nasal formatting (I mean: really bad)
- bad function names (r_type? What about set_refueling_type()?
Then you don't need to explain it in comments.)
- use of dumbed down constants (3.141593 instead of math.pi)
- bogus conversion (nm = m * 0.51444444? With kts to m/s factor?)
(use the constants from globals.nas. I've just added NM2M.
Generally: use symbolic conversion factors instead of
literal numbers, unless it's km->m or hours->sec)
- use fgcommand("add-model") instead of something hand-crafted
- etc. etc.
If someone feels like rushing this in: please fix it first!
Aircraft developers can, of course, stuff into their aircraft
whatever they want (with a few exceptions). But let's keep
the common space clean, please.
m.
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you. Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
