On Thu, Aug 20, 2009 at 8:26 AM, Torsten Dreyer wrote:

> > I agree, we are due for an aggressive -Wall clean up and I'd like to
> remind
> > our active developers that they should consider always compiling with
> > warning flags activated.  The following is pretty standard for me ...
> >
> >     CFLAGS="-Wall -O2" CXXFLAGS="-Wall -O2" ./configure
> >
> > There is a lot of avoidable warnings that have crept into our code in the
> > past few months.
> >
> Message copied ;-)
>
> I just cleaned up all the compiler warnings for SimGear, so it now compiles
> without a single warning.
> At least here on 'gcc (SUSE Linux) 4.3.2 [gcc-4_3-branch revision 141291]'
>
> One actual bug (write behind array size) and one possible bug (use of
> uninitialized variable) were discovered and removed.
>
> While at it, I also commented out the building of tabbed_value_test and
> swap_test in simgear/misc and openal_test[12] in simgear/sound in
> Makefile.am
> If this hurts in any way, they are easily reenabled.


Thanks Torsten!  This effort is long over due!  And we need to continue to
encourage all our developers to turn on the warning flags when they
develop.  Once you get more than a couple "normal" warnings in the code,
they start to hide actual warnings that could indicate real problems or at
least sloppy coding.

Curt.
-- 
Curtis Olson: http://baron.flightgear.org/~curt/
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to