Bertrand, Is this patch supposed to be applied to JSBSim as it currently exists in JSBSim CVS, or applied against the patch that Thorsten mentions?
Jon > -----Original Message----- > From: Bertrand Coconnier [mailto:[email protected]] > Sent: Sunday, February 06, 2011 6:09 AM > To: FlightGear developers discussions > Subject: Re: [Flightgear-devel] JSBSIM Aircraft Crash at Reset > > 2011/2/5 ThorstenB <[email protected]>: > > On 05.02.2011 16:21, ThorstenB wrote: > >> > >> I'm currently testing a different patch for the same issue: instead > >> of untieing all properties below the /fdm/jsbsim (only), I added a > >> list to JSBSim's FGPropertyManagager, so it keeps track of all the > >> properties it has actually bound. It can then use this list to untie > >> all its properties - no matter where these are located in the > >> property tree. > >> > > > > New patch pushed to flightgear/next: > > > http://www.gitorious.org/fg/flightgear/commit/ad8d46ba648263630b8777c5 > > 3f852b75cad7ecdd > > > > This will be overwritten by the next JSBSim update, however it's a > > short-term fix and candidate for our pending 2.2 release. > > So, please test if you still see reset issues with JSBSim aircraft. > If > > we find it's an improvement (maybe/hopefully the final fix for this > > issue), then we'll be pushing this to the 2.2 branch also. But > > remember, none of the reset fixes is part of the 2.2 branch just yet. > > > > The long term fix needs to be part of the JSBSim repository of > course. > > Jon, Erik: please check if you want to use this patch or have some > > other solution to the problem. > > > > Hi Thorsten, > > Good catch ! I had a quick look at your patch and have a couple of > comments on it : > > * Some templates of the Tie() method are located in FGPropertyManager.h > and have been overlooked in your patch (this is quite important because > it leaves a hole in the bottom of which some bugs may have stayed > hidden) > * I would only add the successfully tied properties to the > tied_properties list. In your patch the name of the properties are > unconditionally added to the list. I don't think that does any harm but > the code now looks cleaner to me. > * The method FGFDMExec::checkTied() is now redundant with > FGPropertyManager::Unbind() so the former has been removed in favour of > the latter (this one is rather internal JSBSim stuff, I have included > it for the sake of completeness). > * I would rather make tied_properties a list of SGPropertyNode* rather > than a list of strings (same as above : internal JSBSim stuff) > * Traditionally, method names in JSBSim have the first letter of their > name capitalized (very very minor this one !) > > Attached patch includes all the above suggestions. The patch has been > made against the last revision of the 'next' branch of git. > > Wow ! This issue is really hard to fix. However it exemplifies the Open > Source model superiority in allowing such a team work to fix quite a > reluctant and annoying bug. > > Cheers, > > Bertrand. ------------------------------------------------------------------------------ The modern datacenter depends on network connectivity to access resources and provide services. The best practices for maximizing a physical server's connectivity to a physical network are well understood - see how these rules translate into the virtual world? http://p.sf.net/sfu/oracle-sfdevnlfb _______________________________________________ Flightgear-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/flightgear-devel
