On 23.03.2011 23:22, Bertrand Coconnier wrote: > Attached is a patch that fixes this bug (#294 in the bug tracker). As > far as I could test, it restores the functionality of the instant replay > while keeping the restart feature (CTRL+SHIFT+ESC) functional. > Furthermore I have implemented the 2 methods suspend() and resume() in > JSBSim.cxx so that the FDM is actually suspended during the replay. > > However this bug fix is not really elegant because the original code is > not so elegant itself (see explanations above).
Thanks a lot Bertrand! Using the suspend/resume feature of the subsystem still is elegant, I think. During replay, we really don't want the FDM to do anything - preferably it shouldn't even notice that anything has changed at all. So, suspending the FDM and disabling its callbacks is a good idea. At least easier than disconnecting/reconnecting the property callbacks. It fixes all the issues I have seen and replay works fine now - so I pushed it to git. But are the JSBSim.* files officially maintained in the JSBSim repo (so the patch also needs to be proposed over there) - or are these files owned by FG now? cheers, Thorsten ------------------------------------------------------------------------------ Enable your software for Intel(R) Active Management Technology to meet the growing manageability and security demands of your customers. Businesses are taking advantage of Intel(R) vPro (TM) technology - will your software be a part of the solution? Download the Intel(R) Manageability Checker today! http://p.sf.net/sfu/intel-dev2devmar _______________________________________________ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
