Hi Tim,

The mentioned commit breaks scenegraph picking.
For reference take the c172 door handle that opens the dor but never closes it 
anymore. Well, except you click at the position where the untransformed door 
handle would be.

Also I have some issues with this.
I agree that we should move this into the cull stage. I wanted this also for 
some time now. So, thanks for doing this.

But:
I think we should do this in a usual osg::Transform derived class in the two 
methods computing the transforms.
That would make picking work again.
That would make osgUtil::CullVisitor find some already pooled RefMatrix without 
the need to call new/malloc and delete/free implicitly on each of these nodes.
That would make the nodes work without the EffectCullVisitor and with a plain 
osgUtil::CullVisitor. Sure this could be done by just changing the 
dynamic_cast to the osgUtil::CullVisitor.
Also osg::Matrix has some methods like {pre,post}Mult{Translate,Scale,Rotate} 
which works with O(n^2)~16 operations instead of O(n^3)~64 operations. Ok, the 
rotate method saves less.

Greetings

Mathias

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to