Hi Tom,

I have seem [1], and I don't think it is caused by the linking problem, I
check and experimented the cmake parameter, it's more likely the
implementation of the function in visual studio that's causing it. (the
malloc() within the strdup() is probably using a different heap than the
outside free())

And I don't think what I did only hides the symptoms, since _strdup() is OK
to use in the windows environment. But I do believe the best solution is to
replace this function. If that's required, just let me know, I can replace
it and create a new merge. 

Thanks!

Godspeed

-----Original Message-----
From: Thomas Geymayer [mailto:tom...@gmail.com] 
Sent: Friday, March 01, 2013 4:22 PM
To: flightgear-devel@lists.sourceforge.net
Subject: Re: [Flightgear-devel] How to get my bug fix into the git?

Hi Godspeed,

Am 2013-03-01 10:14, schrieb Zhitao Li:
> I am new to the FlightGear project, I just found and fixed my first 
> bug,

Great ;) I'm not sure if your fix [2] is really a fix or just hiding
symptoms. I currently have no VS available for testing but eg. at [1] it
seems like its a linking problem instead.

> I am wondering how to get my fix into the main git next branch?

You can always open a merge request into the next branch at gitorious.

Tom

[1]
http://stackoverflow.com/questions/8740500/heap-corruption-with-strdup?rq=1
[2]
https://gitorious.org/~plutonium/fg/plutoniums-simgear/commit/0455e8f3253a2b
c26e4a34265e1227984408713a


--
Thomas Geymayer  www.tomprogs.at / C-Forum und Tutorial: www.proggen.org
------------------------------------------------------------------------
      Student of Computer Science @ Graz University of Technology
------------------------------- Austria --------------------------------

----------------------------------------------------------------------------
--
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics Download AppDynamics Lite for
free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel


------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to