Paul McNett wrote: >> I don't have any non-24 bit systems to test on, so it would be nice if >> you could test it -- it's in current SVN (the wxPython 3rd party one...) > > I tested it before submitting on: > > Linux: 8, 16, 24, 32 bit > Mac: 32 bit > Windows: 8, 16, 24, 32 bit
great, thanks. I quick test or to on the patch as applied would be nice, although: >> 1) I wonder if we should bypass the colormatch code on 24bit systems -- >> it's a bit intensive to be run all the time. It is getting used on all systems, so I guess I have tested the patch. > Do you think it matters? It isn't necessary to create that pixel and then > read in > that pixel for 24 or 32 bit, as the next rgb value the generator yields will > work, > however I doubt it is slowing things down enough to worry about. maybe not, but one could have a lot of objects to hit-test, and FloatCanvas object creation is already a bit slow. I suppose profiling is in order before changing anything, though. > +1 on the class idea. I don't like globals either maybe next time I poke into the code. Thanks again for the patch, -Chris -- Christopher Barker, Ph.D. Oceanographer Emergency Response Division NOAA/NOS/OR&R (206) 526-6959 voice 7600 Sand Point Way NE (206) 526-6329 fax Seattle, WA 98115 (206) 526-6317 main reception chris.bar...@noaa.gov _______________________________________________ FloatCanvas mailing list FloatCanvas@mithis.com http://mail.mithis.com/cgi-bin/mailman/listinfo/floatcanvas
