DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Link: http://www.fltk.org/str.php?L2231
Version: 2.0-feature


Honestly said: I don't think that the provided patch is acceptable. You
change Widget::draw_label() to achieve a better layout for a special case
in the browser widget. What else may this affect? It's not enough to
verify that it solves _your_ problem...

Also, I don't understand these lines:

      // Shift first column width, so labels after 1st column are lined up
correctly.
      if (flags & ALIGN_LEFT && cols) {
        cols[0] -= ir.w();
        if (cols[0]==0) cols[0]--;
      }

First point: what, if ir.w() > cols[] ? Are negative cols values
acceptable?

Second point: I can see why there is the special case "if (cols[0]==0)",
but why do you decrement (and not e.g. increment) the cols value,
resulting in -1 (again a negative value).

That said, I'm not a FLTK 2 developer, I only read the code, and I may be
wrong with this...


Link: http://www.fltk.org/str.php?L2231
Version: 2.0-feature

_______________________________________________
fltk-bugs mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-bugs

Reply via email to