A few minor issues and one serious one.  'exit()' is an stdlib function.

The bad one is at the bottom.  But first a few more notes....

In Fluid.

 Missing Alt-B menu selection to toggle the widget bin.  The accelerator
 workd but when the bin goes missing new users will have no idea how to
get it back.
 The menu item used to be in the Edit menu.

---------------------

In the test folder.

 There's a recurring issue with trying to
#include <fltk/Fl.h> This file doesn't exist and I suspect it's left-over code from a transitional
 state between fltk v1.x and v2.x.

 A POSSIBLE fix (also moving it to 2.x version) would be to replace
 that line with

   #include <fltk/run.h>

 And then replace the other includes with their fltk counterparts.  This
 may not always work but it did for the 'connect' test (such as it is).

 This...
   //#include <fltk/Fl_Window.h>
   //#include <fltk/Fl_Toggle_Button.h>

 Then becomes this...
   #include <fltk/Window.h>
   #include <fltk/ToggleButton.h>

 And all the Fl_<Widget_Names> become
     fltk::WidgetNames


-------------------

In the src folder.

 There are two versions of a file chooser.  There's FileChooser and
file_chooser. And there's a third variation in the compat/FL folder. Fl_File_Chooser.

 This is confusing and could likely lead to more problems than it solves.

------------------

re. test/image_file.cxx, missing "nosuch_image" definition.  That's the name
of the missing definition.

// borrowed from fluid. rs->

 #define ns_height 16
 #define ns_width 16
 static unsigned char ns_bits[] = {
   0x00, 0x00, 0x80, 0x01, 0xc0, 0x03, 0xe0, 0x07, 0x80, 0x01, 0x80, 0x01,
   0x80, 0x01, 0x80, 0x01, 0x80, 0x01, 0x80, 0x01, 0x80, 0x01, 0x80, 0x01,
   0xe0, 0x07, 0xc0, 0x03, 0x80, 0x01, 0x00, 0x00};
static fltk::xbmImage nosuch_bitmap(ns_bits, ns_width, ns_height);

Still having probs with this one thinking an fltk::Box is an fltk::Symbol! How'd
THAT happen?   =-O   I think it's declared properly.

In fluid these boxes are fltk::InvisibleBox, even if they have frames
or borders.  I'll try replacing a "Box" declaration with "InvisibleBox"
and see what happens.

-------------

*In fluid designed windows.

When you 'exit(0)' it no longer leaves the application because
this name has used in the fltk system.  This is unfortunate
because there is no compile-time warning that the exit(0)
(#include <stdlib.h>) is not present.
*
The fix may be simple, but this is a fairly serious problem.

You disagree?  Let me put it this way...

It hardly makes sense to do all this extra typing to avoid
name clashes and end up clobbering an stdlib function, does
it?  ;-)

I'm seeing lots of improvements in fltk2 over my old fltk,
but this one is _bad, bad, bad._  This should be fixed asap.

--------------

_______________________________________________
fltk-bugs mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-bugs

Reply via email to