On 04/21/2010 08:32 AM, Duncan Gibson wrote: > > DO NOT REPLY TO THIS MESSAGE. INSTEAD, POST ANY RESPONSES TO THE LINK BELOW. > > [STR Pending] > > Link: http://www.fltk.org/str.php?L2317 > Version: 1.3-current > Fix Version: 1.3-current (r7452) > > > I'm no CMake expert, but saw the following go by in a recent patch: > > +# On unix create backward compatibility symlinks > +if(NOT EXISTS @PREFIX_INCLUDE@/Fl) > + EXECUTE_PROCESS(COMMAND ln -s FL Fl > + WORKING_DIRECTORY @PREFIX_INCLUDE@ > + ) > +endif(NOT EXISTS @PREFIX_INCLUDE@/Fl) > > My question relates to all places where links could be created, not > just this specific example. > > What happens if a "link name" already exists, but is not a link to > the desired target? Eg. the user has made a brute-force copy of a > target to the directory, or there is some debris from a previous > build where the link pointed to a different target. > > Is there, or should there be, some sanity checking that stops and > warns the user to clean up before continuing? > > D. > > > Link: http://www.fltk.org/str.php?L2317 > Version: 1.3-current > Fix Version: 1.3-current (r7452) >
This particular snippet is from the install sequence. As of that particular patch, install time is the only time symlinks are created. The only links created are relative links to an object in the same dir differing in case by one letter. Honestly, I hadn't given it much thought past avoiding error messages on reinstall. I just tested the autotools install, which I usually think should be the guide. It seems to wipe the dir clean on a reinstall, so even externally generated files are removed. You'd only want to do that on the header dir though, if at all. IMHO, deleting individual symlinks should be sufficient. CMake itself uses make-type logic on install. If the target is missing or older than the file to be installed, installation takes place. Otherwise the existing file is left alone. What do you think? Mike _______________________________________________ fltk-bugs mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-bugs
