DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Link: http://www.fltk.org/str.php?L2327
Version: 2.0-current


So i'm a little late to the party, but i'm guessing before _measure() the
img->w() and img->h() values are 12 and 12?
A quick test on my machine got me that, and then digging around the
constructor turned up this:

  Image(const char* name=0) :
    Symbol(name), pixeltype_(fltk::RGB32), w_(12), h_(12),
    picture(0), flags(MEASUREFETCH) {}
This actually creates a 12x12 rectangle that still has MEASURE
requirements (hence the need to call _measure()).

To be honest, I would be willing to call this constructor broken. There
shouldn't ever be a need for a user to be calling a function with either a
prefixed or suffixed underbar. Additionally, especially in the case of
jpegImage, there's actually a shitload of work going on behind the scenes
in the fetch() function, and I wouldn't think this should just be
forgotten about purely because the constructor is defined in one way or
another.
If everyone else has no objections (although I'm guessing it would only be
rainbowsally who would be considering changes to the 2.x branch), I contend
the constructor needs to include a call to fetch(). Otherwise, I think it
runs the risk of being unsafe; before fetch() there is no form of file
checking beyond 'does this file exist'.


Link: http://www.fltk.org/str.php?L2327
Version: 2.0-current

_______________________________________________
fltk-bugs mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-bugs

Reply via email to