DO NOT REPLY TO THIS MESSAGE.  INSTEAD, POST ANY RESPONSES TO THE LINK BELOW.

[STR New]

Link: http://www.fltk.org/str.php?L2409
Version: 1.3-feature


I posted an updated remove-int patch [1] with a small correction [2], a few
changed comments, and removed old debug statements. I also used the new
method at one more place in the old code.

-----
[1] http://www.fltk.org/strfiles/2409/remove-int-r7688.patch

[2] In void Fl_Group::remove(int index) the upper bound of index was
checked, but not the lower bound (0).

+  Fl_Widget &o = *array_[index];

This wouldn't work if children_ == 1, because array_ can be used in
different ways. We need either *array()[index], or *child(index). I chose
the latter because it's equivalent (inline) and is better readable.

-----

I intend to use this new method with my next patch version, i.e. I'll
commit the remove-int patch ASAP, unless someone finds bugs...

Thanks to Greg for the first patch version.

Comments and tests welcome.

Note: currently the patches are mutually exclusive, please test only one
at a time (the newest version of each one).


Link: http://www.fltk.org/str.php?L2409
Version: 1.3-feature

_______________________________________________
fltk-bugs mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-bugs

Reply via email to