> New Revision: 6335 > Log: > added #ifndef FL_DOXYGEN around Flcc_*::methods() to avoid warnings. > > Modified: > branches/branch-1.3/src/Fl_Color_Chooser.cxx
Are the Flcc_HueBox, Flcc_ValueBox and Flcc_ValueInput classes really supposed to be part of the FLTK interface? Or are they supposed to be for internal use only? The Fl_Color_Chooser class has private members of the classes above, so these members can't be accessed by the user. But as the code stands, there is nothing to stop the user creating Flcc_* objects and using them in application code. It seems to me that we could add forward declarations for these classes to Fl_Color_Chooser.H, and then change these members to be pointers and then 'new' them in the Fl_Color_Chooser constructor. Then the actual declarations could be moved to Fl_Color_Chooser.cxx where the internal details could be hidden from the user. In this way only the class names would be exposed. Note that Fl_Color_Chooser.cxx already has the hidden ColorChip class that is used by the fl_color_chooser() function. Is it worth adding this as a \todo or an STR ? D. _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
