Albrecht Schlosser wrote:
> imacarthur wrote:
>> OK - I've pushed the change for #1949, as is. Testing feedback 
>> welcomed. So far, it is "good" on this Mac and the 2 linux variants 
>> I've tried.
> 
> Tested okay for:
> 
> - Linux with system png lib
> - Cygwin with --enable-cygwin and cygwin (system) png lib
> - Cygwin w/o --enable-cygwin with --enable-localpng

I'm sorry, but the last one doesn't work, I didn't see that first 
because I only looked for the defined macros in config.h, and they were 
okay.

With the old configure.in I get:

./configure --enable-localjpeg --enable-localpng --enable-localzlib
checking for gcc... gcc
  [...]
checking for png_set_tRNS_to_alpha in -lpng... (cached) no
  [...]
Configuration Summary
-------------------------------------------------------------------------
     Directories: prefix=/usr/local
                  bindir=${exec_prefix}/bin
                  datadir=${datarootdir}
                  datarootdir=${prefix}/share
                  exec_prefix=${prefix}
                  includedir=${prefix}/include
                  libdir=${exec_prefix}/lib
                  mandir=${datarootdir}/man
        Graphics: GDI
Image Libraries: JPEG=Builtin
                  PNG=Builtin
                  ZLIB=Builtin
  [...]

This is okay: JPEG, PNG, and ZLIB are all "Builtin".


With the _new_ configure.in I get:

./configure --enable-localjpeg --enable-localpng --enable-localzlib
checking for gcc... gcc
  [...]
checking for png_set_tRNS_to_alpha in -lpng... (cached) yes
  [...]
Configuration Summary
-------------------------------------------------------------------------
     Directories: prefix=/usr/local
                  bindir=${exec_prefix}/bin
                  datadir=${datarootdir}
                  datarootdir=${prefix}/share
                  exec_prefix=${prefix}
                  includedir=${prefix}/include
                  libdir=${exec_prefix}/lib
                  mandir=${datarootdir}/man
        Graphics: GDI
Image Libraries: JPEG=Builtin
                  PNG=System
                  ZLIB=Builtin

This is wrong (PNG=System). This does not build the PNG library, and 
compiling Fl_PNG_Image.cxx fails with...

Fl_PNG_Image.cxx:52:28: libpng/png.h: No such file or directory

...and lots of error messages after this.


The following patch fixes this for my cygwin build, but I don't know 
what happens ... :-(

$ svn diff configure.in
Index: configure.in
===================================================================
--- configure.in        (revision 6504)
+++ configure.in        (working copy)
@@ -578,7 +578,7 @@

  AC_ARG_ENABLE(localpng, [  --enable-localpng       use local PNG 
library, default=auto],
      [if test x$enable_localpng = xyes; then
-       ac_cv_lib_png_png_set_tRNS_to_alpha=yes
+       ac_cv_lib_png_png_set_tRNS_to_alpha=no
      fi])

  AC_CHECK_LIB(png,png_set_tRNS_to_alpha, [
@@ -587,7 +587,8 @@
      IMAGELIBS="-lpng $IMAGELIBS"
      AC_DEFINE(HAVE_LIBPNG)
      AC_DEFINE(HAVE_PNG_GET_VALID)
-    AC_DEFINE(HAVE_PNG_SET_TRNS_TO_ALPHA)    AC_CHECK_HEADER(png.h, 
AC_DEFINE(HAVE_PNG_H))],[
+    AC_DEFINE(HAVE_PNG_SET_TRNS_TO_ALPHA)
+    AC_CHECK_HEADER(png.h, AC_DEFINE(HAVE_PNG_H))],[
      if test x$enable_localpng = xno; then
          PNGINC=""
          PNG=""


The first part is _necessary_ to fix the behavior, the second part 
didn't change anything, but it _looks_ as if there has been a missing 
newline, and I fixed (?) this as well.

Any ideas, what's happening?


Albrecht
_______________________________________________
fltk-dev mailing list
[email protected]
http://lists.easysw.com/mailman/listinfo/fltk-dev

Reply via email to