> These two look like the best suggs I've seen so far. > Preference anyone? > > I was gonna pick something and go for a check in later today, > and we'll just 'find out' when folks do compile tests. > > My two cents: it's kinda sounding like #warning is only supported > by gnu.. in which case, maybe the easy answer is just: > > #if defined(__GNUC__) > #warning.. > #endif > > ..??? It would also be ok for me, because in fact ; all devs in the team have at least one gcc compiler available for testing wether it's on *nix, mac os x, win32/mingw or cygwin platforms.
Also, it is always preferable to filter more platforms thus preventing the warning but still compiling, than filtering not enough platforms and potentially break compile on some platform. Fabien > > Fabien Costantini wrote: > > Well, testing WIN32 is too permissive because it would include also mingw > > as an example. > > On the other hand, _MSC_VER would only exclude msvc compilers which is > > better think, but may include borland and watcom compilers. > > I don't think borland compilers support the warning pragma as an example. > > > > Probably filtering all win32 that are not gcc and also sgi would do fine, > > like: > > #if (!defined(WIN32) || defined(__GNUC__)) && !defined(sgi) > > ../.. > > #endif > > Albrecht: > >>>> But if we change (1), then we don't need __CYGWIN__, thus the correct > >>>> solution would be: > >>>> > >>>> #if !defined(_MSC_VER) && !defined(sgi) > >>>> #warning FIXME This needs to be UTF aware now > >>>> #endif > >>>> > >>>> This looks much easier and reflects _compilers_ and not platform > >>>> dependencies. _______________________________________________ fltk-dev mailing list [email protected] http://lists.easysw.com/mailman/listinfo/fltk-dev
